Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+c in terminal does not scroll to the very bottom #5051

Open
Tyriar opened this issue May 1, 2024 · 1 comment
Open

Ctrl+c in terminal does not scroll to the very bottom #5051

Tyriar opened this issue May 1, 2024 · 1 comment
Assignees
Labels
type/bug Something is misbehaving
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented May 1, 2024

Repro:

  1. Set smooth scroll duration to 200
  2. Fill viewport
  3. Scroll up
  4. Press ctrl+c, 馃悰 the terminal is not scrolled to the very bottom

Recording 2024-04-23 at 17 51 44

@Tyriar Tyriar added the type/bug Something is misbehaving label May 1, 2024
@Tyriar Tyriar added this to the 5.6.0 milestone May 1, 2024
@Tyriar Tyriar self-assigned this May 1, 2024
@Tyriar
Copy link
Member Author

Tyriar commented May 1, 2024

Problem line:

// Only scroll the ydisp with ybase if the user has not scrolled up
if (!this.isUserScrolling) {
buffer.ydisp++;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

1 participant