Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wishlist: moving from Mouse to Moo #94

Open
ghost opened this issue Oct 31, 2013 · 15 comments
Open

wishlist: moving from Mouse to Moo #94

ghost opened this issue Oct 31, 2013 · 15 comments
Labels

Comments

@ghost
Copy link

ghost commented Oct 31, 2013

Are you planning to move from Mouse to Moo?

@gfx
Copy link
Member

gfx commented Oct 31, 2013

I have no plan to move to Moo.

Why do you recommend a slower module?

@gfx gfx closed this as completed Oct 31, 2013
@forwardever
Copy link

maybe use p5mop if it should ever become faster than Mouse :)

at least, most of the module is now written in xs, but still alpha software

https://github.com/stevan/p5-mop-redux

@doy
Copy link
Contributor

doy commented Oct 31, 2013

p5mop still has a long way to go before it begins to approach the speed
of Mouse (the goal is to get there eventually, but that's still a ways
off).

@gfx
Copy link
Member

gfx commented Nov 1, 2013

I don't hesitate to move to p5mop in a future, but for now it requires Perl 5.16.0 so I can't use it for Xslate.

@abraxxa
Copy link

abraxxa commented Feb 5, 2014

I'd also prefer Moo over Mouse as the former is already in my (quite big) stack of CPAN modules and the later isn't.

@pangyre
Copy link
Contributor

pangyre commented Feb 5, 2014

While I personally prefer to use Moo most of the time, Mouse(::XS) is much faster and speed is most of the attraction for me in Xslate. So Moo-- here.

@GeJ
Copy link

GeJ commented Feb 5, 2014

After an "interesting" week-end spent at work over the "fatal warnings" switch, I'd rather have Text::Xslate stick to Mouse.

@gfx gfx reopened this Feb 5, 2014
@gfx
Copy link
Member

gfx commented Feb 5, 2014

If I stop using Mouse I prefer to use plain old Perl objects instead of any other OOP framework, but currently I have no time to make such a refactoring anyway.

I'm willing to review patches which drop dependencies on Mouse.

@xsawyerx
Copy link

xsawyerx commented Feb 5, 2014

Have you considered Moo with Class::XSAccessor?

@zdm
Copy link

zdm commented Aug 25, 2014

I think use of plain perl objects is preferable.
Mouse dependency creates additional overhead in projects, where Moo or Moose used.
As i see in sources - Mouse used only in few classes, so porting to perl object would be easy.

@gfx
Copy link
Member

gfx commented Aug 25, 2014

Use of plain perl objects looks the best solution that I, if any, should make. I hope someone make a pull request about it.

@xsawyerx
Copy link

@gfx++

@zdm
Copy link

zdm commented Sep 19, 2014

Also it maybe useful to switch to JSON::XS instead of Data::MessagePack, because JSON::XS is approximately 4 times faster.

@GeJ
Copy link

GeJ commented Sep 20, 2014

As usual YMMV, but with a quick Benchmark script, I found DM to be ~70% faster than JSON::XS when serializing, and ~40% faster when deserializing. I'd rather have DM stay.

@abraxxa
Copy link

abraxxa commented Sep 7, 2017

Is the plan to remove the dependency on Mouse still alive?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants