Make @typescript-eslint/naming-convention ignore non alphanumeric keys #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess you could borrow the regex from here: https://github.com/yeoman/stringify-object/blob/e6ef8e2aa276f79b86a04398df273d45e838a254/index.js#L111 |
|
That's true, but I don't know how to capitalize "$lib", maybe it would make more sense to restrict the regex to "sentence-like" keys ( |
|
I'm back with a crazier edge-case: export default class Ping {
@Get()
''(): string {
//^^ Class Method name `` must match...
return 'pong'
}
} |
|
Disclaimer: not tested |
sindresorhus
reviewed
May 9, 2022
| // Ignore `{'Retry-After': retryAfter}` type properties. | ||
| selector: ['classProperty', 'objectLiteralProperty', 'classMethod', 'objectLiteralMethod', 'typeMethod'], | ||
| format: null, | ||
| modifiers: ["requiresQuotes"] |
There was a problem hiding this comment.
Suggested change
| modifiers: ["requiresQuotes"] | |
| modifiers: [ | |
| 'requiresQuotes' | |
| ] |
|
It needs to be tested for it to be merged. |
|
eslint-config-xo-typescript/index.js Lines 63 to 73 in 286a88e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see #53 for context
\Wmeans[^a-zA-Z0-9_], making keys containing symbols (and thus quoted) ignored by the rule.Fixes #53