Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flatbuffers submodule #169

Open
andresovela opened this issue Aug 2, 2024 · 1 comment
Open

Update flatbuffers submodule #169

andresovela opened this issue Aug 2, 2024 · 1 comment

Comments

@andresovela
Copy link
Contributor

I keep getting build errors when I build xformer (see xmos/ai_tools#909).

ERROR: /home/andy/.cache/bazel/_bazel_andy/8b429239a50f407a9e6918483356d160/external/lib_tflmc/BUILD.bazel:175:11: Compiling tensorflow/lite/micro/arena_allocator/single_arena_buffer_allocator.cc failed: (Exit 1): gcc failed: error executing command (from target @lib_tflmc//:tflmc_lib) /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer '-std=c++0x' -MD -MF ... (remaining 118 arguments skipped)
In file included from external/lib_tflite_micro/lib_tflite_micro/submodules/flatbuffers/include/flatbuffers/array.h:21,
                 from external/lib_tflite_micro/lib_tflite_micro/submodules/flatbuffers/include/flatbuffers/flatbuffers.h:22,
                 from external/lib_tflite_micro/lib_tflite_micro/submodules/tflite-micro/tensorflow/lite/schema/schema_generated.h:7,
                 from external/lib_tflite_micro/lib_tflite_micro/submodules/tflite-micro/tensorflow/lite/micro/memory_helpers.h:22,
                 from external/tflite_micro/tensorflow/lite/micro/arena_allocator/single_arena_buffer_allocator.cc:26:
external/lib_tflite_micro/lib_tflite_micro/submodules/flatbuffers/include/flatbuffers/stl_emulation.h: In member function 'constexpr flatbuffers::span<T, Extent>& flatbuffers::span<T, Extent>::operator=(const flatbuffers::span<T, Extent>&)':
external/lib_tflite_micro/lib_tflite_micro/submodules/flatbuffers/include/flatbuffers/stl_emulation.h:386:12: error: assignment of read-only member 'flatbuffers::span<T, Extent>::count_'
  386 |     count_ = other.count_;
      |     ~~~~~~~^~~~~~~~~~~~~~
Target //:xcore-opt failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 9.925s, Critical Path: 3.75s
INFO: 29 processes: 18 internal, 11 local.
FAILED: Build did NOT complete successfully

The fix is to go to this line and remove the const qualifier.
https://github.com/google/flatbuffers/blob/615616cb5549a34bdf288c04bc1b94bd7a65c396/include/flatbuffers/stl_emulation.h#L465

This variable is no longer declared const on master:
https://github.com/google/flatbuffers/blob/fb9afbafc7dfe226b9db54d4923bfb8839635274/include/flatbuffers/stl_emulation.h#L470

@andresovela
Copy link
Contributor Author

andresovela commented Aug 2, 2024

See google/flatbuffers#7226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant