Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Compress Option #2

Open
EriKWDev opened this issue Jul 20, 2021 · 1 comment
Open

Implement Compress Option #2

EriKWDev opened this issue Jul 20, 2021 · 1 comment

Comments

@EriKWDev
Copy link
Contributor

EriKWDev commented Jul 20, 2021

I see mentions to a -c / --compress option in the comments in the code. The base64 encoded strings can become very large.

Would be nice to implement the compress option :)

Maybe using any of these:

@EriKWDev
Copy link
Contributor Author

EriKWDev commented Jul 21, 2021

I thought a bit about it and I don't know how to implement this without the need for a dependency in the user's project :/

In order to compress we most likely need to depend on a separate library, but then in order to uncompress in the getAsset() proc in the assetfile, it also needs to import that library.

This means that the end project that wants to use nimassets also has to depend on the compression library.

I don't know if that's a big deal or not, but seems like the only option. I personally don't requires("nimassets") in my nimble file, but that might be what everyone else already does and that this is a non-issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant