Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow full static linking and runtime wayland/x11 detection on linux. #3339

Open
ghost opened this issue Feb 25, 2024 · 2 comments
Open

Allow full static linking and runtime wayland/x11 detection on linux. #3339

ghost opened this issue Feb 25, 2024 · 2 comments

Comments

@ghost
Copy link

ghost commented Feb 25, 2024

Is your feature request related to a problem? Please describe.

Trying to use GLFW on wayland is not possible via xmake which is quite irritating.

Describe the solution you'd like

GLFW allows dynamically selecting between X11 and Wayland at runtime which would both make the binaries more portable and fix the glfw on wayland via xmake issue. Changing linux configuration would allow full static builds with this feature.

Describe alternatives you've considered

adding wayland as a feature is possible but it makes xmake configuration for glfw for linux worse [ as you will have to statically choose between X11/wayland]. Plus the binaries produced will not be statically linked and would also pollute the glfw.xmake file.

Additional context

No response

@ghost ghost added the feature request label Feb 25, 2024
@waruqi
Copy link
Member

waruqi commented Feb 26, 2024

you can open a pr to support it.

add wayland/x11 configs and switch them in on_install.

add_configs("glfw_include", {description = "Choose submodules enabled in glfw", default = "none", type = "string", values = {"none", "vulkan", "glu", "glext", "es2", "es3"}})

-- TODO: add wayland support

@ghost
Copy link
Author

ghost commented Feb 27, 2024

GLFW 3.4 has been released and I will have to add that instead..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant