-
Notifications
You must be signed in to change notification settings - Fork 136
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production Level Updates #93
Comments
Hi, Thanks a lot for your interest in the INSTRUCTOR! I welcome all levels of code cleanup! Feel free to open the pull request! |
Raised one such PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If the maintainers of the repo are open to pull requests, would they be interested in a pull request for code cleanup and some production level updates? There are a lot of things in the code that just don't make sense, such as setting the max sequence length and then checking the max sequence length, or neurotically sending models to devices. This isn't great for a more production level deployment when we want to embed millions or billions of documents.
I am going to be making these changes, but I don't want to fork and diverge from the repo. I'd rather that my work be pulled into this repo so that I not only don't have to worry about downstream updates but also it will benefit anyone that uses this.
The text was updated successfully, but these errors were encountered: