fix: change tooltip content when the opacity is 0 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bucketclan
changed the title
|
Great! Thanks for that! @xcarpentier worth merging? |
masanchez-hyve
approved these changes
Feb 16, 2023
t0ma5h
approved these changes
Mar 28, 2023
|
@xcarpentier can you merge please ? Would be nice to get this |
concuacon
approved these changes
Apr 17, 2023
clauds-macedo
approved these changes
Jul 12, 2023
alexdlli
approved these changes
Jul 12, 2023
|
Can this be merged or is this repo not maintained anymore? |
|
I would love to see this merged as well. |
|
In the end I ended up with creating a yarn module of this fork in my own project and included it in my app. |
|
@xcarpentier Can we merge this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121
Without fix:
without.fix.mov
With fix in this PR:
demo.mov
We have a local state in the Modal component which has the content to be shown in the tooltip. So when we switch to the next step we don't end up showing the next steps title immediately, instead we wait for the opacity to be set to 0 and then set the next steps content. Also we store
isFirstStepandisLastStepin state as well as they too are shown in the tooltip.