-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS17 settings bundle sub-localization not working #1058
Comments
This might be connected to the fact that Kodi App uses British English as default ( A test with iOS17 shows that when setting the device to US English the Potential Change: @kambala-decapitator, is there any general guidance on this? The App generally uses British English as root/default and all other translations are derived from it. If we change this, also Weblate needs to be updated. |
quite a nasty situation. Release notes don't seem to have any info about such change. have you tested if the issue with localisation itself or with default text (i.e. key)? Change the same key to 2 different values for US and GB and see if the new value is picked. |
Just confirmed that not the default (key) is shown, but the |
thank you very much. I hoped that we could get away with a trivial fix :) so, as I understand, we should rename |
Wouldn't we need a non-sub-localized
If we do this change w/o changing Weblate the automated translations will screw up as Weblate maps You see any chance that this might be fixed in future iOS? |
iOS 17 Release notes at least point to fixes around localization ("Fixed: Some content might appear in English. Some strings might appear clipped. (109393568)"), could be a regression. |
I saw that, but it says that the issue had actually been fixed :) Difficult to tell what it's about without seeing the original issue. |
For now I personally don't think reworking this on App/Weblate side is worth the hassle. It is quite a minor issue ("Favorites" vs. "Favourites"), but of course such glitch looks like not taking care as settings and app menu now differ for English US. This is clearly an iOS bug, as the PS: I also tried to use different variants for the naming ( |
@gade01, can you share your thoughts on this? The change on the App side is quite simple, but a change to the Weblate logic is needed. |
I definitely recommend keeping en_gb as source language (en). All addons, Kodi core, all components, web interface and everything else use en_gb as source language. |
Thanks. So we should for sure keep UK as leading language. You also recommend to keep using 'en' for English UK? Or is it ok to use 'en' for US and move English UK to 'en-gb'? |
As reported first time in this forum post, the sub-localization of settings.bundle does not work as expected running on iOS17 (simulator or target). In the reported case instead of
en-us
the default Englishen
is used. This only impacts sub-localization, as switching to e.g. German (de
) works. On iOS 15.5 simulation the sub.localization of settings.bundle works as expected.Test case:
The text was updated successfully, but these errors were encountered: