Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Make scroll indicators visible in iOS17 #1056

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

wutschel
Copy link
Contributor

@wutschel wutschel commented May 12, 2024

Description

Closes #1007.

As discussed in #1044 a workaround was found to make the scroll indicator visible again for several views. This PR introduces this workaround for the main library view only. Other view do not seem to be impacted by this problem.

Summary for release notes

Bugfix: Make scroll indicators visible in iOS17

@wutschel
Copy link
Contributor Author

This is crazy. The same workaround in DetailViewController does not work when an instance is used in UIModalPresentationFullScreen -- like done in settings.

@wutschel
Copy link
Contributor Author

I need to correct myself. The problem does not happen on UIModalPresentationFullScreen, but when entering another instance of DetailViewController = browsing through the library or settings.

Example:

  1. Enter movie genres -> indicator visible
  2. Enter a movie gerne and show list of movies -> indicator invisible.

@wutschel
Copy link
Contributor Author

When adding a delay the use case mentioned above works. 0.1 seconds is not enough, 0.5 seconds works quite well so far. Any idea where I could better hook this up? Is there any framework call which comes after viewDidAppear?

@wutschel
Copy link
Contributor Author

@kambala-decapitator, the timeout gave the final hint. Obviously there are still layout related commands called inside DetailViewController's viewDidAppear. The processing finally ends with calling displayData. If I just again set the visibility of the scroll indicator there, the issue is gone -- without a timeout.

@wutschel wutschel marked this pull request as ready for review May 12, 2024 11:43
@kambala-decapitator
Copy link
Collaborator

FYI tried adding setting content offset + scroll to index path to viewDidAppear in a test app - still couldn't reproduce...

@kambala-decapitator kambala-decapitator merged commit a590c60 into xbmc:master Jun 12, 2024
@wutschel wutschel deleted the resolve_scrollindicator branch June 13, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS17 scroll indicators missing
2 participants