Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting episodes duplicates #19

Open
seyguai opened this issue May 1, 2019 · 0 comments
Open

Deleting episodes duplicates #19

seyguai opened this issue May 1, 2019 · 0 comments

Comments

@seyguai
Copy link

seyguai commented May 1, 2019

First of all, nice work !
I might have found some issues when trying to remove duplicates for episodes.

  1. the find_dupids list is filled with imdb and tmdb, but the removal algorithm only matches against imdb
                find_dupids.append(data[options.type[:-1]]['ids']['imdb'])
                find_dupids.append(data[options.type[:-1]]['ids']['tmdb'])
                    if data[options.type[:-1]]['ids']['tmdb'] == dupid
  1. the removal algorithm calls api_remove_from_list with a list of raw ids, but the function wraps that list with shows when the list type is episodes, when the Trakt API expects ids
     if options.type == 'episodes':
            values = { 'shows' : remove_data }
  1. the algorithm fills a list dup_ids with only duplicated ids from find_dupids, but only iterates over find_dupids. In my case, there were some None values in find_dupids, which meant that some episodes where removed without reason
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant