-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.16.0 beta #626
Comments
Thanks a lot for this update. Below are the issues I have encountered after the update:
Here are some suggestions:
|
When I run v1.16.0 beta, the icon never appears in my notification area, even though there are four Twinkle Tray processes running in the background. Downgrading to v1.15.4 immediately solves the problem. I'm on Windows 11 Pro build 22621.2070. |
@Spire42 If you don't mind, can you install the latest beta (v1.16.0-beta2)? If you're still experiencing the issue, can you try manually ending the 4 processes, and then starting Twinkle Tray from the Command Prompt using this command?
Let it run for ~15 seconds and then copy/paste the contents of the console here so I can (hopefully) see what's going on. That would help me greatly. |
@sovalyeler Thanks for the bug report and feedback! I've released v1.16.0-beta2 with a fix for both issues. FYI, you'll need to manually update, as I broke the built-in updater in beta1. Regarding your two suggestions:
|
@Spire42 I actually just noticed a bug related to upgrading to v1.16.0. If you haven't assigned any hotkeys previously, try adding one in v1.15.4 before upgrading. |
@sovalyeler Whoops, I forgot to finish hooking that up. I've fixed the Contrast/Volume hotkey options for the next beta. I'll see about getting multiple actions per hotkey. 👍 |
I set up a hotkey and then upgraded to v1.16.0-beta2, and now everything is working. In retrospect, I realize that should have tried upgrading to v1.16.0-beta2 before setting a hotkey to see which one actually fixed the problem. |
Thanks. Installed #630 (comment) and contrast is working. However I forgot to tell you that when I change contrast by using a hotkey, contrast slider is not updated in UI. After I click on "Refresh displays", it doesn't get updated right away. It needs I think, couple of seconds before the contrast is updated. |
Had the same problem with beta 2, I unisntalled twinkletray using revo uninstaller, cleaned up all the leftover files, reinstalled and the problem was solved, you may not need revouninstaller though; there were very few files left behind |
Hi all, v1.16.0-beta3 is out with several fixes to bugs pointed out by @cerahmed and @sovalyeler. The "no icon in notification area" bug is fixed as well. There was some weirdness in the Profiles system that @cerahmed pointed out that are mostly due to the UI being very incomplete. I'm working on an overhaul of the settings window that should include an easier to understand (hopefully) Profiles UI. |
Installed v1.16.0-beta4, and now I can't change color presets or contrast by hotkey. |
Per the release notes, the hotkeys got reset if you had set them up in a previous v1.16.0 beta. Have you configured them again since upgrading to beta4? |
@sovalyeler Whoops, I forgot to update some of the hotkey logic for multiple actions. Give this version a try: https://github.com/xanderfrangos/twinkle-tray/suites/15207469038/artifacts/869087098 |
Thanks, now second hotkey is working. However other issues persist. Also, I realized that if I change contrast by using contrast slider program doesn't get latest contrast value for hotkey action. For example, my monitor's contrast is 75, and I change it to 0 by using the slider. And then I up the contrast by 20 by pressing a hotkey. However, contrast is now 95, not 20. |
In my case every time I open the config screen it shows up empty. Not even the window actions show up and I have to close it from the tray. |
Hey, all! I haven't had much time to work on Twinkle Tray lately. When I finally get a chance, I'll take a look at the settings window issue and at least add some debugging so I can determine what's breaking it. I also need to look into hotkeys not working as expected. |
As I know latest beta4 had some issues which was solved by this build: https://github.com/xanderfrangos/twinkle-tray/suites/15207469038/artifacts/869087098 , but this is unavailable now. |
Can't toggle "Link levels" using button in tray icon popup twinkle-tray-exe-beta-59fe5260a6f952900eded45128a6e789b6cf0947 |
@xuefer Thanks for the bug report. I'll add that to the list. 👍 |
unrecognized or delayed for samsung CS32JG5X Internal name: SAMOFDE When it's unrecognized, adjusting brightness won't apply it to monitor, yet the monitor is listed in "Monitor Settings" page. "refresh displays" is needed to get out of this buggy state. |
"CS32JG5X Internal name: SAMOFDE" is unable to put to sleep mode "by windows" when twinkle-tray-exe-beta-59fe5260a6f952900eded45128a6e789b6cf0947 is running |
It's taken a lot longer than I intended, but beta5 is finally out. I've spent a lot of time tinkering with the DDC/CI detection process, since it's technically never been correct. It just happened to work for the majority of users. I'm still not entirely convinced that I have it figured out, but from all of my testing it seems to work fine even under very odd configurations. I've also fixed a number of things that have been pointed out, along with improving error handling and debugging options. Hopefully those will help get things on track to wrap up v1.16.0. |
@brogers5 Not sure why I can't replicate it, but I know what should fix it. Try this build: https://github.com/xanderfrangos/twinkle-tray/actions/runs/7434125975/artifacts/1151968575 |
After a bit of research, I have a reasonable level of confidence that I've fixed the issue in this build: https://github.com/xanderfrangos/twinkle-tray/actions/runs/7443684924/artifacts/1153252660 |
@xanderfrangos sorry for not getting back till now, the last build you posted seems to have fixed it! Have restarted/refreshed multiple times and both monitors appear! What Scanning Mode should I leave it in? I've tried Accurate, Fast and No Validation and they all work perfectly fine |
@SupDos Great! Hopefully that's the only hiccup with the new DDC/CI code, but we'll see. I'll roll out a new beta version with this fix for more people to test. You should set the "Scanning Mode" to "Accurate". Thanks again for the help debugging/testing. 👍 |
I've released beta5.2 with the hotkey/monitor fixes. (Nothing new since the build a few comments up.) |
@xanderfrangos Hi, I'm using the latest build v1.16.0-beta5.2 and found that the "Animate Between Times" function is not working as expected, as stated in Issue #661 . For example, in my case today, between Sunrise (08:04) brightness 22 and Solar Noon (12:12) brightness 36, I turned on "Animate Between Times", so I got a brightness of 30 at about 09:00, 28 at 10:00, and 27 at 10:30, which doesn't make sense. I honestly don't know the original intent of this feature, but I think it's supposed to create a smooth curve between two time points, during which the brightness is allowed to smoothly go up/down based on time. I think one of the important features that v1.16 brings to users is the ability to set the change in brightness according to the position of the sun. So, if these two functions can be combined, then automated adjustment of brightness will become very convenient. I would appreciate it if you could take the time to check what the problem is. |
@Atlantis-Gura You're correct that it should be a smooth transition between two times. Can you share your settings file, so I can try to recreate the issue? You can quickly get it from the "Debug" menu, found in the bottom left of the settings window. |
still reproduced with beta v1.16.0-beta5.2. have to refresh display every time |
@xuefer It may be detected by Windows and Twinkle Tray, but not be ready for DDC/CI. Try increasing the "Hardware change time" in the debug menu: Set it to something like 15 seconds as a test. Then after unplugging/plugging it in again, see if it works correctly after around 20 seconds. If that helps, you can try lowering the time until it stops working again and go back up a few numbers. Let me know if that helps. |
nope. waking up from "turn off display", still reproduce the issue with 15 seconds. but manual refresh immediately after wake up make brightness ok |
@xanderfrangos Sure. settings.json After my further testing, the transition between the two times seems to be the opposite of what was expected: from time A (brightness set to 40) to time B (brightness set to 60), the brightness should have transitioned from 40 to 60, but now the brightness is from 60 to 40. This situation is still the same even if the sun position is not used. |
@xuefer If you don't mind, could you generate a report for me before and after the manual refresh? You can find the report button here: @Atlantis-Gura Thanks! The settings and detailed info help. There's definitely something wrong with the math. I'll look into it. |
@Atlantis-Gura The calculations should be fixed in this build: https://github.com/xanderfrangos/twinkle-tray/actions/runs/7466557973/artifacts/1157848291 |
@xanderfrangos After a simple test now the problem seems to be solved and the transition between the two times works fine. Thanks for your help! |
1-before.txt |
I can confirm that with v1.16.0-beta5.2 the Settings window works as it used to and it doesn't show up empty anymore. Fix was implemented in v1.16.0-beta5 but I didn't update until now. |
@xuefer Weird. Can you give this build a try and let me know if it helps? It refreshes twice after a hardware change. So in theory it should be doing what you've been doing manually, automatically. https://github.com/xanderfrangos/twinkle-tray/actions/runs/7493620770/artifacts/1163423754 |
not helping. but it seems i have found the problem. it can't detect hardware change. when i unplug/plug another monitor, devmgmt.msc refresh itself, but twinkle-tray does not refresh(remove or add) the monitor. is there anything I should check? "Shell Hardware Detection" service is running, not disabled |
@xuefer Interesting. I've added a different method for detecting hardware changes in this build. In theory, it should fix the issue: https://github.com/xanderfrangos/twinkle-tray/actions/runs/7514246889/artifacts/1167454272 |
this one is ok. btw, 2 seconds delay works for both of my external screens |
|
@zhouym233 Thanks for providing the report. 👍 Does it work if you set "DDC/CI Scanning Mode" to "Fast" or "Legacy"? |
Also, can you share a report from when it's working (using "No validation")? |
It works in "Legacy" and "Fast" mode too. but after I changed the options a few times, it probably doesn't work again . "Accurate" mode never works. |
Interesting, thanks for confirming all of that. Have you used an earlier version of Twinkle Tray (like v1.15.4) before without issue? |
Yes, v1.15.4 works , but occasionally it had some issues with hotkeys, so I updated to the beta version. |
Unlike the windows volume adjustment bar, the twinkle tray scrolling bar for the systray and taskbar popup has no exiting animation. |
Older versions of Twinkle Tray had exit animations, but due to the tray flyout and hotkey flyout sharing the same renderer, it was too much trouble to maintain. Maybe one day I'll give it another try, but I have to finally get v1.16.0 out the door before I work on something like that. It's not a high priority. I appreciate the suggestion though. |
Any news when it will come? |
After Windows auto turns off the display feature executes and the display turns off itself, the brightness level does not retain the last set level. |
Hi all,
I have big a new update to Twinkle Tray that I'd love to get some feedback on. There are several new features that have been requested for a long time. I've still got a few things to figure out with the functionality and how it's presented, so the UI/language may change. I'll set up the localization strings once the dust settles.
The current release notes are:
The beta is available here:
https://github.com/xanderfrangos/twinkle-tray/releases/tag/v1.16.0-beta5.2
Let me know if you encounter any new issues vs v1.15.4. Thanks!
The text was updated successfully, but these errors were encountered: