Same name for inner classes leads to "share same reference" error

[alexvoronov]

Hi,

I have multiple classes all having a nested class called "Param". When I try to generate schema, I get ValueError: Types <class '__main__.B.Params'> and <class '__main__.A.Params'> share same reference 'Params':

from dataclasses import dataclass
from typing import Union

from apischema.json_schema import deserialization_schema


@dataclass
class A:
    @dataclass
    class Params:
        a: int

    params: Params  # A.Params


@dataclass
class B:
    @dataclass
    class Params:
        b: int

    params: Params  # B.Params

deserialization_schema(Union[A, B], all_refs=True)

I understand that I can annotate each inner Param with apischema.type_name, giving each of them a unique name, but that's manual work.

Is it possible to use reference factory to create unique names automatically, e.g. based on type hierarchy? From what I see, reference factory takes only string "ref", that is the class name, and not the class itself that can be used to inspect the hierarchy. Is there any way around it?

[alexvoronov]

This is not an answer, more of a comment to my original question. Annotation apischema.type_name works really well, with some regex magic I annotated all conflicting inner classes (I had a few dozen of them) in quite a short time. I guess a more general solution is not really needed.