Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxJava3 Support #14

Open
michaelcarrano opened this issue Jun 25, 2019 · 1 comment
Open

RxJava3 Support #14

michaelcarrano opened this issue Jun 25, 2019 · 1 comment

Comments

@michaelcarrano
Copy link
Contributor

Roxie is built using RxJava2 and RxJava3 is in the works.

Things to think about:

  • The operators that we currently use, are they still available? Do their behavior change?
    • If not available, what do we use instead?
    • If behavior change, does it break our implementation? What do we use instead?
  • Should we provided an RxJava2 artifact? What Roxie is today.

https://github.com/ReactiveX/RxJava/releases/tag/v3.0.0-RC0

@nschwermann
Copy link

nschwermann commented Oct 27, 2019

It doesn't look like there are any breaking changes to PublishSubject or CompositeDisposable so the library should only need a package change. I am thinking rather than having an Rx2 artifact it would be better to break Roxie into modules. The Base would be pretty much unchanged however there can be a different implementations for the ViewModel (rx2, rx3 and coroutine channel/flow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants