Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Add an option to completely disable Preview mode, or Preview on demand #56

Open
hongc-cc opened this issue Sep 10, 2020 · 3 comments
Open

[FR] Add an option to completely disable Preview mode, or Preview on demand #56

hongc-cc opened this issue Sep 10, 2020 · 3 comments
Assignees
@reganlawton
Labels
good first issue Good for newcomers

Comments

@hongc-cc
Copy link

Not urgent at all.

Our client usually have 10-20 instagram embeds in one single entry.
The current preview might initiate a very long load time ( i have seen 28s) when loading into the entry editing page.
Plus, if some instagram embeds failes (say, wrong link, removed post), it's even longer.

Cache could help, but i think another option is just to not preview at all.
User might only want to check when they add it in the entry.
@reganlawton
Copy link
Member

So "Previews hidden by default" not enuf? THe feature can be sorted if not.

@hongc-cc
Copy link
Author

hongc-cc commented Sep 10, 2020 •
edited
Loading

Even it is hidden by default, it still renders.

Screenshot 2020-09-11 at 7 07 52 AM

@reganlawton
Copy link
Member

No issues I'll look into the change and have a setting to "Disable Preview"

@reganlawton reganlawton added the good first issue Good for newcomers label Jul 21, 2021
@reganlawton reganlawton self-assigned this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reganlawton reganlawton

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reganlawton @hongc-cc