Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tide haults auditing when it encounters a plugin not on WP.org #130

Open
bbonahoom opened this issue Jul 6, 2023 · 3 comments
Open

Tide haults auditing when it encounters a plugin not on WP.org #130

bbonahoom opened this issue Jul 6, 2023 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@bbonahoom
Copy link

bbonahoom commented Jul 6, 2023

Bug Description

PHP Compatibility Scanner v1.6.2 Scan stuck on Gravity Forms 2.7.9 after casting an error (Response status: 404 Message: The audit requested does not exist.) for Gravity Edit 2.0

Expected Behaviour

Complete scan and move on to other plugins

Steps to reproduce

  1. Start scan

Screenshots

image

Additional context

  • Tide version:
  • Node version:
  • Docker version (if applicable):
  • OS:
  • Browser: [e.g. chrome, safari]
  • Device: [e.g. iPhone8]

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

Implementation brief

QA testing instructions

Demo

@bbonahoom bbonahoom added bug Something isn't working needs triage Further action is required labels Jul 6, 2023
@jeffpaul
Copy link
Member

@bbonahoom https://wordpress.org/plugins/search/Gravity%2520Edit/ does not appear to be a valid plugin on the wp.org repo. I'm closing this as Tide only audits plugins available publicly on the wp.org repo.

@jeffpaul jeffpaul closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2023
@bbonahoom
Copy link
Author

@jeffpaul - you missed the point of my problem. Sorry if I didn't state it clear enough. Tide didn't skip over the plugin. It. Got. Stuck. My expected behavior is that it call the scan complete and move on. Not to get stuck on plugins it doesn't recognize.

@jeffpaul jeffpaul reopened this Jul 12, 2023
@jeffpaul jeffpaul changed the title Gravity Edit & Gravity Forms Tide haults auditing when it encounters a plugin not on WP.org Jul 12, 2023
@jeffpaul jeffpaul added this to the 1.1.0 milestone Jul 12, 2023
@jeffpaul jeffpaul added help wanted Extra attention is needed and removed needs triage Further action is required labels Jul 12, 2023
@pbiron
Copy link

pbiron commented Oct 22, 2023

My expected behavior is that it call the scan complete and move on. Not to get stuck on plugins it doesn't recognize.

I completely agree with the above! Not only are there premium plugins (eg. Gravity Forms), but there are also "site-specific" plugins that aren't going to be in the .org repo.

For any plugin encountered during a scan that is not in the .org repo, the PHP Compatibility Checker plugin should simply report "Plugin X is not in the .org repo and so we can't report which versions of PHP it is compatible with." and go on to the next plugin.

As is, I can no longer scan any site I work on, as they all have either premium or "site-specific" plugins (and most have both).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants