Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve vendor dep error handling for malformed files #229

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve vendor dep error handling for malformed files #229

wants to merge 2 commits into from

Conversation

sciencewhiz
Copy link
Contributor

Does not parse hidden files. Fixes wpilibsuite/GradleRIO#726
Identifies file that failed to load or parse

@sciencewhiz
Improve vendor dep error handling for malformed files
dddb72d 
Does not parse hidden files. Fixes wpilibsuite/GradleRIO#726
Identifies file that failed to load or parse
@sciencewhiz
Copy link
Contributor Author

The error printed before was from deep within GSON, such as:

An exception occurred applying plugin request [id: 'edu.wpi.first.GradleRIO', version: '2024.2.1']
> Failed to apply plugin class 'edu.wpi.first.gradlerio.wpi.WPIPlugin'.
   > Could not create an instance of type edu.wpi.first.gradlerio.wpi.WPIExtension.
      > java.nio.charset.MalformedInputException: Input length = 1

now its:

An exception occurred applying plugin request [id: 'edu.wpi.first.GradleRIO', version: '2025.1.1-beta-1-8']
> Failed to apply plugin class 'edu.wpi.first.gradlerio.wpi.WPIPlugin'.
   > Could not create an instance of type edu.wpi.first.gradlerio.wpi.WPIExtension.
      > Failed to parse vendor dependency: ._REVLib.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starlight220 Starlight220 Starlight220 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vendordeps glob should skip hidden files
2 participants
@sciencewhiz @Starlight220