Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[simulation] Fix multiproject Gradle support problems #688

Closed

Conversation

spacey-sooty
Copy link
Contributor

Fixes #687

@ThadHouse
Copy link
Member

This won't actually work. Your project is hitting the case where 0 binaries are specified. And we don't want to make that just be silently ignored.

@ThadHouse
Copy link
Member

It's the wpi.cpp.enableExternalTasks(it) in the binary definition that adds the binary to the simulation task.

@spacey-sooty
Copy link
Contributor Author

Yeah I started testing it and I realised this. I've made another change to improve the error message a bit.

@spacey-sooty
Copy link
Contributor Author

@ThadHouse maybe if we see you only have non executable binaries we print that out as a warning and peacefully exit at that point?

@ThadHouse
Copy link
Member

Thats not the issue. Currently, the task is created automatically whenever the gradlerio plugin is applied. It is then up to the project to explicitly add a binary to the simulation task. Thats what the call to wpi.cpp.enableExternalTasks(it) in the binary definition does. The sim task doesn't attempt to automatically add any binaries, and doesn't have access to do that either.

Basically the way to solve this would be to only create the sim tasks if wpi.cpp.enableExternalTasks(it) is called, instead of eagerly creating them, as happens currently.

@spacey-sooty spacey-sooty deleted the fix-subproject-sims branch July 8, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent simulation builds
2 participants