Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote experimentalToolbar out of experimental #1811

Open
4 tasks
blakewilson opened this issue Feb 21, 2024 · 0 comments
Open
4 tasks

Promote experimentalToolbar out of experimental #1811

blakewilson opened this issue Feb 21, 2024 · 0 comments

Comments

@blakewilson
Copy link
Contributor

blakewilson commented Feb 21, 2024

Similar to taking the plugin system out of experimental, let's take the toolbar out of experimental as well.

We should still support the experimentalToolbar property in the config, but if used, console a warning that they should be using toolbar instead and that experimentalToolbar will be removed in the next major release.

Take a look at the PR for taking the plugin system out of experimental for inspiration:
#1807

Acceptance Criteria

  • Deprecate shouldShowFaustToolbar property and log a warning when encountered, tell user to use shouldShowAdminToolbar which is controlled by the wp-admin setting on the user's profile.
  • Use shouldShowAdminToolbar property to control Toolbar rendering
  • Be mindful of bundle size increase when including Toolbar
  • Write new issue to remove backwards compatibility in next major semver release

If we determine that enabling this by default causes an unacceptable performance hit, we will disable it by default until a later time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant