-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App goes blank when interacting with "larger" websites #122
Comments
Let me look into this and see if I can reproduce it. Can you let me know your system specs and OS version? |
Processor |
Thanks for that, I've managed to replicate the issue on an Intel device and I'm looking into the cause. |
I've isolated this down to the amount of data being returned from the snippets exceeding the max that the renderer can handle when they're all enabled. The short term fix is to only enable required snippets. I'll be increasing the limits and optimising the way data is handled in the next release. |
Thank you! |
I had this same issue - is there any way to recover or save what it crawled so far? Is it saved somewhere? Im also on a macbook pro m1. Also, if a crawl crashes like this - but I managed to save some of the crawl - is there a way to pick up where it left off? |
Unfortunately there's not a way to recover a crawl right now. If you can sit tight a little it's my priority to resolve this. I'm currently re-engineering how the data is stored so this won't happen and opening up more memory to the app. You're more likely to run into the problem if you're enabling all the snippets. Selectively enable only the ones you want. The main culprits that are pushing the memory usage over the edge are the RAW HTML and Critical CSS snippets, as they return a lot of data to the table. (Aside: My son was born a few days ago and my attention is there currently but I'll be looking at this as soon as I can) |
Just an update to let you know I've been working on this and have been busy re-engineering how Horseman handles data so the Chromium memory limit isn't reached when all snippets are enabled. |
Congrats on the birth of your son. I consistently run into this issue, even with enabling some of the snippets although admittedly, Im grabbing the full html. |
Thanks. I've largely resolved this now, just onto the last few fixes and tests. Unfortunately it's taken longer than expected as it required quite a substantial rewrite of some core functionality. Unfortunately running as a VM with more RAM won't resolve this as the limit that's being reached is hard coded limit within Electron/Chromium. It's made worse on MacOS as the ceiling is even lower. Can I ask your reason for returning the full HTML to the table? |
The few custom snippets I tried to create (im not a developer, so relying
on chatgpt) didnt work and I dont want to re-crawl the site.
Grabbing the html lets me use code interpreter or gpt4 creating beautiful
soup scripts to help me parse out what I need later.
…On Wed, Aug 23, 2023, 5:17 AM Chris Johnson ***@***.***> wrote:
Thanks. I've largely resolved this now, just onto the last few fixes and
tests. Unfortunately it's taken longer than expected as it required quite a
substantial rewrite of some core functionality.
Unfortunately running as a VM with more RAM won't resolve this as the
limit that's being reached is hard coded limit within Electron/Chromium.
It's made worse on MacOS as the ceiling is even lower.
Can I ask your reason for returning the full HTML to the table?
—
Reply to this email directly, view it on GitHub
<#122 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABL4TPEFWFDWPL3HK6IYQHLXWXRDVANCNFSM6AAAAAAZPUNW4Y>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Ahh, are you using the JSON or CSV export for this? As a side note I'm more than happy to help you with custom snippets to get them to do what you want. |
The text was updated successfully, but these errors were encountered: