-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CamelCase usernames get added as lower-case into DB and result in access issues #3614
Comments
Isn't this independent from the names? It should use IDs. Which tables does this affect? Only Because looking at the code, there's no |
I focused on I don't know yet where the issue is coming from and what causes it. The only thing I can say that I could reproduce it in my private instance (creating a new user with a CamelCase name) and patching usernames from lowercase to CamelCase fixed a lot of access issues the respective users in the CB instance. |
Component
server
Describe the bug
When a username is in camel-case, e.g.
MyUser
, the user get's added asmyuser
into the DB (e.g. theorgs
table).This causes access issues during use. Users only see the generic "an unknown error occured" when accessing their own user org and other access-restricted parts within WP.
We have hundreds of these cases in the Codeberg instance (https://codeberg.org/Codeberg-CI/feedback/issues/149). Additionally, I also verified this behavior with a new user on my own private instance.
Not sure if it is forge-related, but it at least affects Gitea/Forgejo.
System Info
Additional context
No response
Validations
next
version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]The text was updated successfully, but these errors were encountered: