Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Tap to Pay contactless limit description for the UK #14758

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Update Tap to Pay contactless limit description for the UK #14758

wants to merge 1 commit into from
+8 −3

Conversation

staskus
Copy link
Collaborator

@staskus staskus commented Dec 23, 2024

Closes: #14723

Description

Based on the clarification made in pdfdoF-5ZW-p2#comment-7215, I'm adding a bit more detail into the UK TTP payment limit description.

Steps to reproduce

  1. Log into the UK store pdfdoF-5Vk-p2 on iPhone
  2. Go to Menu -> Payments -> About Tap to Pay
  3. Confirm the first page shows a contactless limit notice at the bottom

Testing information

No extra tests required for localization change.

Screenshots

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@staskus staskus added type: enhancement A request for an enhancement. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. labels Dec 23, 2024
@staskus staskus added this to the 21.4 milestone Dec 23, 2024
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14758-4e4fd08
Version21.3
Bundle IDcom.automattic.alpha.woocommerce
Commit4e4fd08
App Center BuildWooCommerce - Prototype Builds #12286
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@iamgabrielma iamgabrielma self-assigned this Dec 24, 2024
@iamgabrielma
Copy link
Contributor

Works as described!

We just happen to have a test for that string! test_for_gb_configuration_a_formatted_limit_paragraph_is_provided() which doesn't pass CI now, I'll approve the PR just be sure to address it before merge :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamgabrielma iamgabrielma iamgabrielma approved these changes

@jaclync jaclync Awaiting requested review from jaclync

Assignees

@iamgabrielma iamgabrielma

Labels
feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: enhancement A request for an enhancement.
Projects
None yet
Milestone
21.4
Development

Successfully merging this pull request may close these issues.

TTP: Modify UK TTP limitations for clarity
3 participants
@staskus @wpmobilebot @iamgabrielma