-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product Query [4]: Implement layout options #42490
Product Query [4]: Implement layout options #42490
Comments
Hi @sunyatasattva,
As the link was not working for me, so adding following screenshot for further reference:
Does this mean that we can hide existing Layout panel & then add a new Layout option? Also, I can see that you have this PR on woocommerce-blocks repo & this PR for Gutenberg repo. But I don't see any discussion on both of these PRs. Because of this I have 2 queries:
|
Hello @imanish003 This one is a hard topic. The main discussion is here: https://github.com/woocommerce/woocommerce-blocks/discussions/8276 But since then, these PRs have been referenced a bunch of times honestly. Once I can remember off the top of my head is in this conversation: https://wp.me/per0F9-ns But maybe you'll find also more things in the PT comments. I believe in any case that we require alignment with Gutenberg. So perhaps the conversation can be continued in the GitHub discussion thread? |
Hi @sunyatasattva,
As mentioned in the issue description. Should we consider using CSS to hide the existing layout panel? |
Hey @imanish003 ! I think at this point the best would be to discuss it with design and get Jarek up to speed on this perhaps. So that we don't do something that's unaligned with GB again. |
Thanks for the suggestion, @sunyatasattva. 🙌🏻 I agree that it would be good to have a discussion with design and Jarek to ensure that we align with GB. 🤝 I'll reach out to them and see if we can schedule a meeting to discuss the options and decide on the best approach. I noticed that you have created a PR on the GB repo. I will try to keep in sync with interesting discussions going on there. 🤝 |
This is a placeholder issue for when the spec of the layout options is finalized.
FIgma Design: UmuaN1XXqCa6myOHkb0ZWy-fi-1207%3A116374&t=a12roEsuCt8ErZjq-0
Note that ideally, this layout panel will be integrated with the existing one where needed. Since this is currently not possible in Gutenberg, hacky solutions like CSS hiding are allowed as per this comment (pdnLyh-30z-p2#comment-1948).
Whether settings should be duplicated in the toolbar and inspector controls, or only implemented in the inspector controls it's still a decision to be made.
cc @vivialice
The text was updated successfully, but these errors were encountered: