Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert no-reviews-placeholder.js to no-reviews-placeholder.tsx and replace propTypes with TypeScript definitions #42362

Closed
nielslange opened this issue May 19, 2023 · 0 comments · Fixed by #44664 · May be fixed by woocommerce/woocommerce-blocks#10249
Closed

Convert no-reviews-placeholder.js to no-reviews-placeholder.tsx and replace propTypes with TypeScript definitions #42362

nielslange opened this issue May 19, 2023 · 0 comments · Fixed by #44664 · May be fixed by woocommerce/woocommerce-blocks#10249
Assignees
@thealexandrelara
Labels
team: Kirigami & Origami WC Store Editing (FSE) type: cooldown Things that are queued for a cooldown period (assists with planning). type: enhancement The issue is a request for an enhancement. type: refactor The issue/PR is related to refactoring.

Comments

@nielslange
Copy link
Member

Problem

assets/js/blocks/reviews/reviews-by-product/no-reviews-placeholder.js is a JS file and uses propTypes definitions.

Expected outcome

  1. Convert the file from no-reviews-placeholder.js to no-reviews-placeholder.tsx.
  2. Replace propTypes with TypeScript definitions.
@nielslange nielslange added type: enhancement The issue is a request for an enhancement. type: refactor The issue/PR is related to refactoring. type: cooldown Things that are queued for a cooldown period (assists with planning). labels May 19, 2023
@hritikchaudhary hritikchaudhary mentioned this issue Jun 8, 2023
Open
@hritikchaudhary hritikchaudhary mentioned this issue Jun 1, 2023
Closed
7 tasks
@hritikchaudhary hritikchaudhary mentioned this issue Jul 18, 2023
Open
7 tasks
@nerrad nerrad added the team: Kirigami & Origami WC Store Editing (FSE) label Nov 21, 2023
@ObliviousHarmony ObliviousHarmony transferred this issue from woocommerce/woocommerce-blocks Dec 11, 2023
@thealexandrelara thealexandrelara self-assigned this Feb 15, 2024
@thealexandrelara thealexandrelara mentioned this issue Feb 15, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thealexandrelara thealexandrelara

Labels
team: Kirigami & Origami WC Store Editing (FSE) type: cooldown Things that are queued for a cooldown period (assists with planning). type: enhancement The issue is a request for an enhancement. type: refactor The issue/PR is related to refactoring.
Projects
None yet
Milestone
No milestone
3 participants
@nerrad @nielslange @thealexandrelara