This repository has been archived by the owner on Oct 11, 2022. It is now read-only.
forked from ngs/draft-js-markdown-shortcuts-plugin
-
Notifications
You must be signed in to change notification settings - Fork 42
Can not select all content in code-block if disabling renderLanguageSelect
#81
Labels
Comments
I think the right solution to this issue would have to allow content to be wrapped in Maybe the issue here is that the |
This comment has been minimized.
This comment has been minimized.
@mxstbr the issue happens when |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
It turns out, I'm not so smart—it does the exact thing you're saying in Chrome, but not in Firefox! I think this is related to https://github.com/withspectrum/spectrum/issues/2897 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I tried to get rid of language select and set
renderLanguageSelect
in config as the function that returns''
. Now I dont see the language select but code became not selectable.@mxstbr the same happens in the
spectrum
app https://www.dropbox.com/s/hfagg1nr6sgakhs/Screenshot%202018-05-21%2015.44.36.png?dl=0 (try to start a code block and press cmd+a)Maybe we should make custom code component optional? Because now even if
renderLanguageSelect
return empty, content is still wrapped inCodeSwitchContainer
https://github.com/withspectrum/draft-js-markdown-plugin/blob/master/src/components/Code/index.js#L11The text was updated successfully, but these errors were encountered: