Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): add util.spawn() #5342

Merged
merged 47 commits into from
Apr 28, 2024
Merged

feat(sdk): add util.spawn() #5342

merged 47 commits into from
Apr 28, 2024

Conversation

garysassano
Copy link
Collaborator

@garysassano garysassano commented Dec 26, 2023

Closes #5341

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@garysassano garysassano requested a review from a team as a code owner December 26, 2023 18:04
@monadabot
Copy link
Contributor

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @eladb
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @skorfmann
Wing Playground @eladcon

@monadabot
Copy link
Contributor

monadabot commented Dec 26, 2023

Console preview environment is available at https://wing-console-pr-5342.fly.dev 🚀

Last Updated (UTC) 2024-04-24 12:09

@monadabot
Copy link
Contributor

monadabot commented Dec 26, 2023

Benchmarks

Comparison to Baseline ⬜🟥🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 60ms±1.06 62ms±0.61 +2ms (+3.03%)⬜
functions_1.test.w -t sim 394ms±4.54 409ms±6.9 +15ms (+3.74%)🟥
functions_1.test.w -t tf-aws 820ms±10 842ms±6.76 +22ms (+2.66%)🟥
jsii_big.test.w -t sim 2816ms±27.86 2806ms±14.88 -11ms (-0.37%)⬜
jsii_big.test.w -t tf-aws 3023ms±14.89 3009ms±9.41 -14ms (-0.46%)⬜
functions_10.test.w -t sim 492ms±7.96 494ms±10.07 +2ms (+0.41%)⬜
functions_10.test.w -t tf-aws 2028ms±11.38 2041ms±14.41 +13ms (+0.63%)⬜
jsii_small.test.w -t sim 369ms±5.82 373ms±3.53 +4ms (+1.11%)⬜
jsii_small.test.w -t tf-aws 605ms±6.27 611ms±3.8 +6ms (+0.95%)⬜
empty.test.w -t sim 365ms±3.95 369ms±3.42 +4ms (+1.07%)⬜
empty.test.w -t tf-aws 601ms±2.96 599ms±4.09 -2ms (-0.29%)⬜
hello_world.test.w -t sim 405ms±4.82 406ms±10.27 +1ms (+0.32%)⬜
hello_world.test.w -t tf-aws 1526ms±10.07 1522ms±8.89 -4ms (-0.27%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 62ms 60ms 63ms 1ms 1ms
functions_1.test.w -t sim 409ms 398ms 428ms 7ms 10ms
functions_1.test.w -t tf-aws 842ms 828ms 854ms 7ms 9ms
jsii_big.test.w -t sim 2806ms 2764ms 2843ms 15ms 21ms
jsii_big.test.w -t tf-aws 3009ms 2991ms 3028ms 9ms 13ms
functions_10.test.w -t sim 494ms 476ms 524ms 10ms 14ms
functions_10.test.w -t tf-aws 2041ms 2011ms 2077ms 14ms 20ms
jsii_small.test.w -t sim 373ms 366ms 381ms 4ms 5ms
jsii_small.test.w -t tf-aws 611ms 603ms 617ms 4ms 5ms
empty.test.w -t sim 369ms 362ms 379ms 3ms 5ms
empty.test.w -t tf-aws 599ms 593ms 610ms 4ms 6ms
hello_world.test.w -t sim 406ms 397ms 446ms 10ms 14ms
hello_world.test.w -t tf-aws 1522ms 1500ms 1542ms 9ms 12ms
Last Updated (UTC) 2024-04-24 12:15

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Dec 26, 2023
eladb
eladb previously requested changes Dec 30, 2023
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing test

libs/wingsdk/src/util/util.ts Outdated Show resolved Hide resolved
libs/wingsdk/src/util/util.ts Outdated Show resolved Hide resolved
libs/wingsdk/src/util/util.ts Outdated Show resolved Hide resolved
libs/wingsdk/src/util/util.ts Outdated Show resolved Hide resolved
Copy link

Hi,

This PR has not seen activity in 20 days. Therefore, we are marking the PR as stale for now. It will be closed after 7 days.
If you need help with the PR, do not hesitate to reach out in the winglang community slack at winglang.slack.com.
Feel free to re-open this PR when it is still relevant and ready to be worked on again.
Thanks!

@tsuf239 tsuf239 removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 21, 2024
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 22, 2024
Copy link
Collaborator

@tsuf239 tsuf239 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@staycoolcall911 staycoolcall911 dismissed eladb’s stale review April 24, 2024 12:04

Changes applied - missing test was added

@tsuf239 tsuf239 removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 28, 2024
Copy link
Contributor

mergify bot commented Apr 28, 2024

Thanks for contributing, @garysassano! This PR will now be added to the merge queue, or immediately merged if garysassano/util-spawn is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Apr 28, 2024
mergify bot added a commit that referenced this pull request Apr 28, 2024
mergify bot added a commit that referenced this pull request Apr 28, 2024
@mergify mergify bot merged commit 10e0dbf into main Apr 28, 2024
25 checks passed
@mergify mergify bot deleted the garysassano/util-spawn branch April 28, 2024 08:51
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.73.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add util.spawn()
6 participants