fix(console): respect node.title in the map view
#6464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the display of node names in the MapView component to show the title if available, falling back to the id if not. Fixes #6457.
|
Thanks for opening this pull request! 🎉
|
|
Console preview environment is available at https://wing-console-pr-6464.fly.dev 🚀 Last Updated (UTC) 2024-05-16 12:44 |
eladb
approved these changes
May 13, 2024
We have to revisit the test suite and then we could start adding the tests back. But right now they are just being skipped. |
|
Bummer
…On Mon, May 13, 2024 at 12:32 PM Cristian Pallarés ***@***.***> wrote:
Is there a way to test this?
We have to revisit the test suite and then we could start adding the tests
back. But right now they are just being skipped.
—
Reply to this email directly, view it on GitHub
<#6464 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAESGDF6GB7DZJQ6QD7MQPLZCCCCTAVCNFSM6AAAAABHTVZ6MGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBXGA4TIMZZGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
ainvoner
requested changes
May 13, 2024
ainvoner
approved these changes
May 16, 2024
|
Thanks for contributing, @skyrpex! This PR will now be added to the merge queue, or immediately merged if |
14 tasks
|
Congrats! 🚀 This was released in Wing 0.73.49. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the display of node names in the MapView component to show the title if available, falling back to the id if not.
Fixes #6457.