Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some settings missing from automoduleconfig output #274

Open
willkg opened this issue Dec 3, 2024 · 0 comments
Open

some settings missing from automoduleconfig output #274

willkg opened this issue Dec 3, 2024 · 0 comments

Comments

@willkg
Copy link
Owner

willkg commented Dec 3, 2024

Tecken has a settings file that uses the Everett configuration manager here:

https://github.com/mozilla-services/tecken/blob/cc26d300104edd3d2736a934e737b678b6dba2b6/tecken/settings.py

The docs use automoduleconfig to extract configuration documentation from that file:

https://github.com/mozilla-services/tecken/blob/cc26d300104edd3d2736a934e737b678b6dba2b6/docs/configuration.rst#L41

However, there are a lot of settings that don't make it to the configuration. For example:

  • DOWNLOAD_S3_BUCKET
  • DOWNLOAD_S3_REGION

In the settings.py file, those are conditionally set depending on the cloud provider value. Maybe automoduleconfig skips that?

This covers fixing automoduleconfig so it documents those variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant