Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New package]: typos_lsp #1562

Closed
1 task done
mawkler opened this issue Nov 22, 2023 · 8 comments
Closed
1 task done

[New package]: typos_lsp #1562

mawkler opened this issue Nov 22, 2023 · 8 comments
Labels
help wanted Extra attention is needed new-package-request

Comments

@mawkler
Copy link

mawkler commented Nov 22, 2023

I've searched open & closed issues for similar requests

  • Yes

Package name

typos_lsp

Package homepage

https://github.com/tekumara/typos-vscode

Languages

No response

How is this package distributed?

GitHub release files: https://github.com/tekumara/typos-vscode/releases

@williambotman
Copy link
Collaborator

Hello! Pull requests are always very welcomed to add new packages. If the distribution of the package is simple, the installation will most likely be so as well. See CONTRIBUTING.md and the API reference for more details! You may also use existing packages as reference.

 🤖 This is an automated comment.    📖 Source code 

@williambotman williambotman added the help wanted Extra attention is needed label Nov 22, 2023
@mawkler
Copy link
Author

mawkler commented Nov 22, 2023

For the record, Mason has typos and typos_lsp is a LSP wrapper on top of typos, which was just added to nvim-lspconfig: neovim/nvim-lspconfig#2886

@mehalter
Copy link
Contributor

Mason also already has typos-lsp to install as well: mason-org/mason-registry#3546

@chrisgrieser
Copy link

typos_lsp has been added to the mason registry in this PR 5 days ago: mason-org/mason-registry#3546

Thus, this issue can be closed

@mawkler
Copy link
Author

mawkler commented Nov 29, 2023

Awesome!

I'm assuming that typos_lsp has to be added in some form to server.lua in mason-lspconfig.nvim, because currently I'm getting the following error after adding typos_lsp to ensure_installed?:

[mason-lspconfig.nvim] Server "typos_lsp" is not a valid entry in ensure_installed. Make sure to only provide lspconfig server names.

@chrisgrieser
Copy link

@mawkler nvim-lspconfig and mason use different package names, which is causing the error.

If you are using both, the simplest solution is to install mason-lspconfig which solves that problem for you by matching the different names automatically for you.

@mawkler
Copy link
Author

mawkler commented Nov 29, 2023

@chrisgrieser

install mason-lspconfig

That's what I did, I was referring to mason-lspconfig.nvim's ensure_installed. But typos_lsp doesn't seem to be listed in mason-lspconfig's file that I linked which I assume is how the mapping is dones 🙂

@mawkler
Copy link
Author

mawkler commented Nov 29, 2023

Oh never mind, I'm just a dumb dumb that forgot to run :LazyUpdate. My bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed new-package-request
Projects
Status: Closed
Development

No branches or pull requests

4 participants