Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename folder #511

Open
lighthunt opened this issue Aug 20, 2020 · 18 comments · May be fixed by #563
Open

Rename folder #511

lighthunt opened this issue Aug 20, 2020 · 18 comments · May be fixed by #563
Labels
good first issue Good for newcomers

Comments

@lighthunt
Copy link
Contributor

Would it be possible to add rename option into context menu for folders, just like it is possible to rename files/videos (on disk)? Would help me to organize my data/folders directly in VHA without a need to re-scan over and over again. Thank you.

Btw, are the auto tags generated from folder names too? (use-full for me)

@whyboris
Copy link
Owner

This seems like a very useful feature. It's doable, just will take some development time.

I'm happy to accept a PR for it 😁 🤝 🙂

For the UI I imagine just re-using the same rename modal that pops up when you right-click -> rename video, but instead of a filmstrip, it would show the folder icon with the four preview screenshots from videos inside 🤔

I'm unsure if good first issue is a good label for this -- since it's not a super-simple code change to make, but I'll help anyone who wants to give it a try -- even first timers 👍

@whyboris whyboris added the good first issue Good for newcomers label Aug 20, 2020
@ghost
Copy link

ghost commented Aug 22, 2020

Hello, can I try my hand at this one?

@whyboris
Copy link
Owner

Absolutely! 🤝 🙇 👍
Please let me know if you have any trouble -- reach out any time!

@ghost
Copy link

ghost commented Aug 22, 2020

Hello,
I thought I could do this, but I realized I don't have enough experience/knowledge to pull this off. Sorry about the inconvenience. :( Is it okay if I back out?

@whyboris
Copy link
Owner

No problem at all! Thank you for trying 🤝

As I commented above, I'm unsure if good first issue is a good label, since there are quite a few moving parts:

  • adding code to node to rename a folder
  • adding code to Angular (which requires being/getting a bit familiar with Angular)
    • adding rename modal to folders
    • refactoring / editing the current rename modal
  • handling various errors that could happen 😅

I'm able to do it all, but if I am to do it, it won't be part of 3.0.0 (the first release) as I'm very eager to release sooner rather than later. And this feature, while very nice to have, isn't essential.

@shubham13695
Copy link

Hello @whyboris can i try this ?

@whyboris
Copy link
Owner

whyboris commented Sep 4, 2020

Thanks @shubham13695 🤝 -- please feel free to reach out with questions of any kind 👍

@FonsecaJoao
Copy link

@shubham13695 Any update? If you need help feel free to ask. Glad to help.
I'm a junior front end dev with 1.5y exp with Angular

@whyboris
Copy link
Owner

Hey @FonsecaJoao -- it's been long enough with no updates (and @shubham13695 doesn't seem to have a fork of this repository either). Please feel free to take this 🙇

For reference, you have half year more experience with Angular than when I started this app 😉

Please feel free to reach out with any questions 😁

@shubham13695
Copy link

Hi @whyboris I cloned the project and started working on it but I stuck at the electron part where you already have the code to rename a file the same code I used for folder rename but I don't know how to trigger that change in APP.

@FonsecaJoao you can take this

@whyboris
Copy link
Owner

@shubham13695 -- do you have a fork of the code online so we could see the changes you are describing?

For reference -- all the messaging between Node and Angular happen through ipc (Inter-Process Communication) - look for anything that starts with ipc for reference. It's a matter of sending a message and listening for the same message name on the other end 😉

@shubham13695
Copy link

shubham13695 commented Oct 14, 2020

i emitted data from ipc renderer but the folder name does not change the rightClickItem Object .I will fork the project first. so that you can help me.

@whyboris
Copy link
Owner

@shubham13695 -- I gave a talk and at this point of the talk I describe how the messaging works. Might be useful (the section is only about a minute long) 👍

@FonsecaJoao
Copy link

Hi @whyboris I cloned the project and started working on it but I stuck at the electron part where you already have the code to rename a file the same code I used for folder rename but I don't know how to trigger that change in APP.

@FonsecaJoao you can take this

Can you share your cloned project? Or fork and copy the changes to that fork?

@shubham13695
Copy link

@whyboris I forked the project and changes also pushed. please review it. if there is any suggestion or I did something wrong please let me know. it is a pleasure to work on this project. I m still facing the issue of reflecting the folder name change. what I think is you were changing the file name with an index.

@FonsecaJoao please review it.

@whyboris
Copy link
Owner

Hey @shubham13695 thank you 🙂
I don't see your PR yet or your branch: https://github.com/shubham13695/Video-Hub-App/branches
Perhaps you still have to push your development branch to your forked repository? 🤔

@shubham13695
Copy link

@whyboris I m getting a code refactor issue. i m fixing that

@whyboris
Copy link
Owner

whyboris commented Oct 21, 2020

Thank you for the PR #563 🤝

@whyboris whyboris linked a pull request Oct 21, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants