-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename folder #511
Comments
This seems like a very useful feature. It's doable, just will take some development time. I'm happy to accept a PR for it 😁 🤝 🙂 For the UI I imagine just re-using the same rename modal that pops up when you right-click -> rename video, but instead of a filmstrip, it would show the folder icon with the four preview screenshots from videos inside 🤔 I'm unsure if |
Hello, can I try my hand at this one? |
Absolutely! 🤝 🙇 👍 |
Hello, |
No problem at all! Thank you for trying 🤝 As I commented above, I'm unsure if
I'm able to do it all, but if I am to do it, it won't be part of |
Hello @whyboris can i try this ? |
Thanks @shubham13695 🤝 -- please feel free to reach out with questions of any kind 👍 |
@shubham13695 Any update? If you need help feel free to ask. Glad to help. |
Hey @FonsecaJoao -- it's been long enough with no updates (and @shubham13695 doesn't seem to have a fork of this repository either). Please feel free to take this 🙇 For reference, you have half year more experience with Angular than when I started this app 😉 Please feel free to reach out with any questions 😁 |
Hi @whyboris I cloned the project and started working on it but I stuck at the electron part where you already have the code to rename a file the same code I used for folder rename but I don't know how to trigger that change in APP. @FonsecaJoao you can take this |
@shubham13695 -- do you have a For reference -- all the messaging between Node and Angular happen through |
i emitted data from |
@shubham13695 -- I gave a talk and at this point of the talk I describe how the messaging works. Might be useful (the section is only about a minute long) 👍 |
Can you share your cloned project? Or fork and copy the changes to that fork? |
@whyboris I forked the project and changes also pushed. please review it. if there is any suggestion or I did something wrong please let me know. it is a pleasure to work on this project. I m still facing the issue of reflecting the folder name change. what I think is you were changing the file name with an index. @FonsecaJoao please review it. |
Hey @shubham13695 thank you 🙂 |
@whyboris I m getting a code refactor issue. i m fixing that |
Thank you for the PR #563 🤝 |
Would it be possible to add rename option into context menu for folders, just like it is possible to rename files/videos (on disk)? Would help me to organize my data/folders directly in VHA without a need to re-scan over and over again. Thank you.
Btw, are the auto tags generated from folder names too? (use-full for me)
The text was updated successfully, but these errors were encountered: