Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-step gate *negative* offset #253

Open
hotelbachelard opened this issue Nov 26, 2020 · 5 comments
Open

Per-step gate *negative* offset #253

hotelbachelard opened this issue Nov 26, 2020 · 5 comments

Comments

@hotelbachelard
Copy link

Hi,

I'd love to be able to do a negative gate offset on a step. Currently you can only go between 0 and 87. 5%, but you can't make the step trigger earlier. The screen also puts the 0% mark in the middle, so I assumed that you can go to negative values.

Many thanks!

@hotelbachelard hotelbachelard changed the title Per-step gate offset Per-step gate *negative* offset Nov 26, 2020
@vafu
Copy link

vafu commented Dec 1, 2020

Hi, I have a PR with negative offsets implemented and I need some help testing it, would you mind trying my changes?
#234

@hotelbachelard
Copy link
Author

hotelbachelard commented Dec 1, 2020 via email

@hotelbachelard
Copy link
Author

Hey @vafu - your latest version has a glitch. In the Step mode/page, normally, you can only turn on/off a step gate when you're on the Gate menu/page (1st tab, 1st item), and you need to press on the step + encoder when you're on any other menu (Retrig, Note, etc). But with your latest version, you can activate gate on/off from any page. Not sure if that's what you want - I personally prefer to be able to alter the gate sequence only in the Gate menu, so it's harder to accidentally alter the gate pattern while I'm trying to just change note values or gate lengths, etc.

I reloaded the official 0.1.39 firmware to confirm, because that's what I remember, and confirm that's the case.

@vafu
Copy link

vafu commented Dec 6, 2020

@hotelbachelard yes, thanks! I've added this as my own preference but I accidentally added these changes to the firmware update, sorry about that, I'm going to remove that asap!

@hotelbachelard
Copy link
Author

Hey @vafu - I found a lil bug in your 1.39: the Gate Probability bar doesn't show up in your version. :(
20210227_212900
it's there in 1.40 (and the official 1.39)
20210227_213108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants