-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(werf): add application version param support #6439
Conversation
Hi! Thank you for your work and the proposed solution. The feature looks useful overall, but there are a few points we need to discuss. For example, using We’ll take a pause and will get back to you soon with a proposal to improve your solution. |
Thanks for you work! After discussion, we decided that the feature should be implemented this way: # werf.yaml
deploy:
helmChartConfig:
appVersion: <app version goes here> With Go templating capabilities of werf.yaml we can already do this: appVersion: {{ env "VERSION" }} and this: appVersion: {{ (.Files.Get "version.yaml" | fromYaml).version }} and probably this: appVersion: {{ (.Files.Get "version.json" | fromJson).version }} so no need for This |
Hi Ilya, thank you for the feedback. I like the idea of using the integrated Go templating capabilities you mentioned. I will dive into |
2b08bdd
to
1afe493
Compare
Done. PS I found a way to override parent's Chart.yaml |
LGTM, thanks! Can you squash commits and sign them so that this will pass: https://github.com/werf/werf/pull/6439/checks?check_run_id=33876806421 |
Implements werf#6390 Signed-off-by: Ilya Drey <[email protected]>
1afe493
to
96a99b5
Compare
Done |
Implements #6390
The current implementation scope:
applicationVersion
global param support towerf.yml
applicationVersionFile
global param support towerf.yml
applicationVersionFile
paramsapplicationVersionFile
paramapplicationVersionFile
paramapplicationVersion
andapplicationVersionFile
params are setapplicationVersion
value is available in nelm templates by using$.Values.werf.applicationVersion
variableInline set application version by
applicationVersion
paramwerf.yaml
file content:Set application version by external JSON file
werf.yaml
file content:./version.json
file content:Set application version by external YAML file
werf.yaml
file content:./version.yaml
file content:Set application version by external plain/text file
werf.yaml
file content:./version
file content: