Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup does not work for images built with Buildah #6373

Closed
1 task done
alexey-igrychev opened this issue Oct 25, 2024 · 0 comments · Fixed by #6437
Closed
1 task done

Cleanup does not work for images built with Buildah #6373

alexey-igrychev opened this issue Oct 25, 2024 · 0 comments · Fixed by #6437

Comments

@alexey-igrychev
Copy link
Member

Before proceeding

  • I didn't find a similar issue

Version

1.2.330 / 2.10.10

How to reproduce

  1. Build images using Buildah backend.
  2. Attempt to run the cleanup command for the built images.
  3. Observe the behavior.

Result

The cleanup command keeps the images and removes stages associated with them.

Expected result

The cleanup command should successfully keep the images and stages associated with them.

Additional information

This is related to the bug Buildah #3866. During cleanup, our logic excludes the entire stage chain by using the digest obtained after the build. With Buildah, there is currently no way to retrieve the actual digest without publishing to a container registry.

We can wait for the issue to be resolved in Buildah. Still, we will take an alternative approach by decoupling the cleanup logic from the digest in favor of image tags, which, in the case of werf, already serve as a unique identifier for the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant