Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not delete default keys from subcharts if subchart is defined in dependencies #128

Open
1 task done
shcherbak opened this issue Oct 3, 2024 · 4 comments
Open
1 task done

Comments

@shcherbak
Copy link

Before proceeding

  • I didn't find a similar issue

Version

2.10.9, 1.2.329

How to reproduce

Could not delete default keys from subcharts if subchart is defined in dependencies

if subchart has for example

resources:
  limits:
    cpu: 4
    memory: 3Gi
  requests:
     cpu: 700m
     memory: 70Mi

it is unable to override with

resources:
  limits: null
  requests: null

the same as helm/helm#9027

Result

default values are in rendered files

Expected result

default values are overrided

Additional information

No response

@alexey-igrychev
Copy link
Member

Thank you for your feedback. We will work on addressing this issue.​

@alexey-igrychev alexey-igrychev transferred this issue from werf/werf Oct 23, 2024
@ilya-lesikov
Copy link
Member

@shcherbak You said that you specified null overrides as this:

resources:
  limits: null
  requests: null

but instead it must be like this:

# .helm/values.yaml
mysubchart:  # name of the subchart as defined in dependencies
  resources:
    limits: null
    requests: null

If done this way is the problem still persist?

@shcherbak
Copy link
Author

@ilya-lesikov of cource I specified values with mysubchart key

@ilya-lesikov
Copy link
Member

We'll look into it. Either Helm issue or we messed up somewhere when backporting changes from Helm upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants