Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why lower case "ldap-username-field"? #56

Open
Daniel-H76 opened this issue Mar 15, 2019 · 1 comment
Open

Why lower case "ldap-username-field"? #56

Daniel-H76 opened this issue Mar 15, 2019 · 1 comment

Comments

@Daniel-H76
Copy link

Wekan uses the "username" field for email salutation ("Dear username,") and subject line ("admin sent you an invitation") and we can use "ldap-username-field" to fill it with something usefull via LDAP authentication.
As the field doesn't support spaces (will get replaced by dots) it makes most sense to use the "givenname" attribute in my opinion. Unfortunately it gets converted to lower case.

"Dear Daniel" would be a much nicer salutation than "Dear daniel". Any chance to preserve the case? Otherwise I'd recommend to use the "Full Name" within emails (this one preservce the case).

@xet7 xet7 transferred this issue from wekan/ldap Apr 20, 2019
@adelphi-company
Copy link

and we can use "ldap-username-field" to fill it with something usefull via LDAP authentication.
As the field doesn't support spaces (will get replaced by dots) it makes most sense to use the "givenname" attribute in my opinion.

It seems that it is NOT a good idea to fill the ldap-username-field by the givenName attribute : If two users are having the same username Wekan totally gets confused. Only one user is created but the profile information is mixed up (full name changes after login but e-mail doesnt).

Therefore I like to request a new case sentitive field for email salutation (e.g. ldap-salutation-field) and recommend to keep the ldap-username-field by something more unique, e.g. userprincipalname.

@xet7 xet7 transferred this issue from wekan/wekan Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants