Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design a better structure for the Antarctic regions bounding box polygon container #208

Open
weiji14 opened this issue Dec 3, 2020 · 0 comments
Labels
enhancement ✨ New feature or request

Comments

@weiji14
Copy link
Owner

weiji14 commented Dec 3, 2020

Scattered across deepicedrain's various scripts is a 'regions' variable (also 'ice_boundaries', 'drainage_basins', etc) that holds a geographical bounding box and/or polygon which is needed for spatial subseting and plotting operations. However this is getting really messy/unwieldy and should be vendored off at some point to a package like regionmask.

This 'regions' container should hold Antarctic geographical boundaries (both a Polygon and BoundingBox) and have a 'placename' (e.g. "amundsen_sea_embayment") and 'full name' (e.g. "Amundsen Sea Embayment") attribute.

Related: d2b0199, 85b6ffa, #190

@weiji14 weiji14 added the enhancement ✨ New feature or request label Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant