-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileSink::IsolatedFlush returns false on success #1178
Comments
@maruthiaws, I don't understand your reply. All I see is the code for Filter::Flush which appears to be an exact copy of what I quoted, excluding formatting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The documentation for IsolatedFlush in BufferedTransformation states that IsolatedFlush should return true on success.
The FileSink code returns false on success:
The only place where this has a consequence in the library is in FIlter::Flush, where there may be an unintended fallthrough:
The text was updated successfully, but these errors were encountered: