You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What version of this package are you using?
master@14fe83f
What operating system, Node.js, and npm version?
Windows 11, nodejs v16.13.1, npm 8.1.2
What happened?
Each time a piece is stored when all selections are fulfilled (eg: removing a selection) causes WebTorrent to announce completed to the trackers. This causes completed to be announced multiple times. I believe this is caused by _checkDone not checking for currently outstanding piece reservations outside of the current selections.
What did you expect to happen?
For completed to only be announced once all reservations are downloaded/cancelled.
Are you willing to submit a pull request to fix this bug?
yes
Steps to reproduce
Add a magnet URI with &so= appended to the end of the URI (Removes default selection)
Add a file to a <video> using .streamTo
Play and then pause the video to add and remove selections
Observe the tracker to see multiple completed events being announced
The text was updated successfully, but these errors were encountered:
What version of this package are you using?
master@14fe83f
What operating system, Node.js, and npm version?
Windows 11, nodejs v16.13.1, npm 8.1.2
What happened?
Each time a piece is stored when all selections are fulfilled (eg: removing a selection) causes WebTorrent to announce completed to the trackers. This causes completed to be announced multiple times. I believe this is caused by _checkDone not checking for currently outstanding piece reservations outside of the current selections.
What did you expect to happen?
For completed to only be announced once all reservations are downloaded/cancelled.
Are you willing to submit a pull request to fix this bug?
yes
Steps to reproduce
&so=
appended to the end of the URI (Removes default selection)<video>
using.streamTo
The text was updated successfully, but these errors were encountered: