-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: HTTP Digest auth support #821
Comments
Nice work! We can combine this with an older example from issue #470 and make a PR out of it. I am unlikely to prioritize this in the next few weeks since I am not using an HTTP auth proxy, so if someone wants to submit a PR, it would be very welcome. |
I don't often implement proxies with digest auth so I want to crowdsource an answer for which common proxy I should test the HTTP digest auth implementation against. Please add your comment here to vote for a proxy. I want to implement this feature in parallel with adding a proxy into the CI unit tests, because right now the CI does not use an actual proxy during testing and therefore the code coverage don't fully cover the proxy code, which should be fixed. |
It would be nice to support HTTP Digest authentication.
It could be easily implemented in the _handshake.py.handshake() by checking for the 401 status and the Authorization response header. I made a very dirty hack just to test it and works well (this supports only the most simple Digest auth).
The text was updated successfully, but these errors were encountered: