Closing mdns agent #636
Merged
Closing mdns agent #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Oups - so sorry, this was a github-editor patch. I was hoping to have the time this evening to check the fix on my use-case, and wanted to give a heads-up to @r-byondlabs to look at it. But I didn't anticipate you being so fast! Fixed the code. The tests pass on my machine. |
|
Cargo fmt warning |
I use the library with many open/close, and I get mdns storms where the webrtc library searches for other nodes over the network in a very aggressive manner. This has been proposed by @r-byondlabs, and might very well be the problem: if I open/close many connections, and the mdns-agents are not cleaned up, there might be many requests. Fixes webrtc-rs#616
|
Here you go. With my version of cargo-fmt, it also changes the formatting of two other files. Let me know if that's OK. I tested it on my setup, and the mdns-storms seem to be effectively gone, which is great! I also added devbox and a pre-commit hook here: #637 . I'm a recent devbox-convert and really think it improves the contributor experience a lot. |
rainliu
approved these changes
Nov 21, 2024
tubzby
pushed a commit
to tubzby/webrtc-rs
that referenced
this pull request
Nov 26, 2024
I use the library with many open/close, and I get mdns storms where the webrtc library searches for other nodes over the network in a very aggressive manner. This has been proposed by @r-byondlabs, and might very well be the problem: if I open/close many connections, and the mdns-agents are not cleaned up, there might be many requests. Fixes webrtc-rs#616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use the library with many open/close, and I get mdns storms where the webrtc library searches for other nodes over the network in a very aggressive manner.
This has been proposed by @r-byondlabs, and might very well be the problem: if I open/close many connections, and the mdns-agents are not cleaned up, there might be many requests.
Fixes #616