Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this rewriting can affect dynamically generated content on the page #879

Open
the-blank-x opened this issue Jan 20, 2024 · 0 comments
Open

Comments

@the-blank-x
Copy link

Describe the bug

pywb rewrites all this uses to use a wrapper. However, the rewriting can be a bit overzealous, since it does so inside strings. For example, document.querySelector("p").innerText = "well, this is awkward" gets rewritten into document.querySelector("p").innerText = "well, _____WB$wombat$check$this$function_____(this) is awkward"

Steps to reproduce the bug

  1. Download test.warc.gz
  2. wb-manager init test
  3. wb-manager add test test.warc.gz
  4. Go to http://localhost:8080/test/http://localhost:8000/ (for an example), or http://localhost:8080/test/https://stainedglasswoman.substack.com/p/slivers (for an occurance in the wild)

Expected behavior

The rewrite to not hapen inside strings

Screenshots


Environment

  • OS: Arch Linux
  • Browser: Librewolf
  • Version: 121.0-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant