-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[💡 Feature]: Compatibility with ESLint flat config and more precise exported types for wdio ESLint driver #12547
Comments
Thanks for reporting! We greatly appreciate any contributions that help resolve the bug. While we understand that active contributors have their own priorities, we kindly request your assistance if you rely on this bug being fixed. We encourage you to take a look at our contribution guidelines or join our friendly Discord development server, where you can ask any questions you may have. Thank you for your support, and cheers! |
@gavvvr thanks for raising the issue. We haven't been able to update our existing plugin to be compatible with the new plugin system of Eslint. Any contributions that would us get there would be very much appreciated. |
Hi @christian-bromann |
Reviewed the PR and it looks good to me, I want someone else from the team take a look as well. Thanks a lot! |
Thanks @MadSandwich for working on a fix for this 🙏 closing! |
Is your feature request related to a problem?
Hi. Trying to to configure wdio eslint plugin in modern typescript project and using the new "flat" config system of ESLint. Here are my observations:
tseslint.config(...)
function and@ts-check
enabled foreslint.config.js
Describe the solution you'd like.
Ideally, I would expect wdio ESLint plugin to be pluggable in couple of lines (not sure if it's possible though):
Describe alternatives you've considered.
While the above does not work, I manually try to apply the plugin piece by piece in
eslint.config.js
:So, I am also struggling to apply the plugin piece by piece, because TS treats values of
configs.recommended.rules
object as strings, while a more narrow types are expectedAdditional context
typescript-esltint
projecteslint
andtypescript-esltint
now encourage to use the so-called "flat" config@ts-check
+tseslint.config(...)
is recommended bytypescript-esltint
in their Getting Started guideCode of Conduct
The text was updated successfully, but these errors were encountered: