Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

music.youtube.com connector doesn't work for a few days #4613

Closed
NorthernBlow opened this issue Mar 26, 2024 · 9 comments · Fixed by #4704
Closed

music.youtube.com connector doesn't work for a few days #4613

NorthernBlow opened this issue Mar 26, 2024 · 9 comments · Fixed by #4704
Labels
bug Something isn't working

Comments

@NorthernBlow
Copy link

NorthernBlow commented Mar 26, 2024

Describe the bug
music yotube connector works fine until last three days and after upgradee broken

Environment

  • OS: Arch Linux
  • Browser: Firefox
  • Extension version: Latest
@NorthernBlow NorthernBlow added the bug Something isn't working label Mar 26, 2024
@flavioislima
Copy link

I can confirm it doesn't work for me as well for both Linux (Arch and OpenSuse) on Firefox and Vivaldi.
But also doesn't work on Windows as well for same browsers:

Music is playing but still cannot recognize it:
image

Tried restarting the browser, reinstalling the extension, logging out and in again from Last.Fm and still nothing works.

@NorthernBlow NorthernBlow changed the title music.youtube.com connector doesn't work a few days music.youtube.com connector doesn't work for a few days Mar 28, 2024
@TheColorman
Copy link

Probably related to #4587. Works fine for me on Windows/Google Chrome + Chrome desktop PWA. The rework made the connector use the javascript api for playing media, is your browser correctly detecting the music?

@zbigniewzolnierowicz
Copy link

Can confirm the same error on macOS + Firefox.

@vpzomtrrfrt
Copy link

vpzomtrrfrt commented Mar 31, 2024

I see information in navigator.mediaSession.metadata while playing so it does seem to exist

though weirdly it's null if I set a breakpoint in the connector code, is that running in a different context?

@NorthernBlow
Copy link
Author

NorthernBlow commented Apr 1, 2024

on Windows 10 + Firefox same problem, Windows 11 + Firefox same, Manjaro Linux + Firefox the same

@CECTPAyTkyHECu
Copy link

Have the same problem too on Windows 11 and Firefox

@abrown19
Copy link

abrown19 commented Apr 10, 2024

Oddly enough, this is working fine for me in Microsoft Edge only (Windows 10 and Windows 11) using the plugin version from the Edge Add-ons site. The other browsers I've tested (firefox, chrome, vivaldi) using the Mozilla or Chrome Web Store versions are reporting errors. The extension can submit now playing information but does not scrobble and reports a general error (!) from the extension.

Using the latest build artifact (Windows 11, Chrome/Vivaldi) listens/scrobbles correctly the first time. Now playing data is sent correctly and shown in the extension, but subsequent scrobbles/listens are "errored" in the cache. Selecting errors from cache and using the scrobble button does not work and deletes them from the cache.

@TheColorman
Copy link

TheColorman commented Apr 16, 2024

Maybe related, but I get a "The track is not recognized" notification for every song, but it detects just fine on Google Chrome.

@1shira
Copy link
Contributor

1shira commented May 12, 2024

I did some testing and discovered, that the navigator Object that the extension accesses is not the same that the page accesses in Firefox.

I tried setting the navigator.mediaSession myself to debug, when setting it and then setting
track = navigator.mediaSession.metadata?.title, the extention show's what I have set, while the browser console still shows the song currently playing.
Even after removing the code that sets the mediaSession, it stayed as what I had set while the console on the page always showed the currently playing song.

It seems the extention gets it's own navigator Object from Firefox and cannot access the navigator the page uses, causeing the extention to be unable to detect anything on Firefox with the current implementation.

I suggest using selector classes like before #4587 since the version before still works or accessing the navigator object through an injected script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants