Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show default edits in the page and allow modification #4644

Open
soreikomori opened this issue Apr 13, 2024 · 0 comments
Open

Show default edits in the page and allow modification #4644

soreikomori opened this issue Apr 13, 2024 · 0 comments
Labels
feature New feature or request

Comments

@soreikomori
Copy link

Is your feature request related to a problem? Please describe.
web-scrobbler has a few default edits like removing "(feat. x)" or "(Music Video)" from scrobbles. This is great in most cases to keep last.fm clean, but it can cause some issues sometimes, especially when web-scrobbler is used in tandem with another scrobbler in another platform (say in Android), since one scrobbler might remove those tags and the other won't. In the end, this should be left to the discretion of the user- If I want my track to have the "(feat. x)" then web-scrobbler should have an option to stop executing those default edits.

Describe the solution you'd like
To give the user more control over what exactly gets edited out, the default web-scrobbler edits such as that one should be shown in the regex/bulk edits page in the extension settings, and simply be turned on by default. The user then should be able to remove them if need be.

Describe alternatives you've considered
Maybe a single slider button that can enable or disable "recommended edits" or "default edits" or something of the sort.

@soreikomori soreikomori added the feature New feature or request label Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant