New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web-push-php API signature change #345
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I lost countless hours trying to make it send the payload.
I used this code
Subscription::create([ 'endpoint' => $endpoint, $p256dh, $keys_auth, 'contentEncoding' => 'aesgcm', ]),
Notice I used position parameters and it gives no error (except in the case of "endpoint").
Instead, it should be like this:
Subscription::create([ 'endpoint' => $endpoint, 'publicKey' => $p256dh, 'authToken' => $keys_auth, 'contentEncoding' => 'aesgcm', ]),
I think it should raise an error if any of the parameters is provided without a name.
The text was updated successfully, but these errors were encountered: