Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diagnostics if builtins.define is failed to parse #6242

Open
h-a-n-a opened this issue Apr 15, 2024 · 0 comments
Open

Improve diagnostics if builtins.define is failed to parse #6242

h-a-n-a opened this issue Apr 15, 2024 · 0 comments
Labels
contrib: easy pr welcome team The issue/pr is created by the member of Rspack.

Comments

@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Apr 15, 2024 •
edited

Improve diagnostic for the builtins.define. Parse should never end up in a program panic. Check out the original issue down below.

I've closed this issue for not a bug. Feel free to reopen it if rspack should report a friendly message here to improve dx.

Originally posted by @xc2 in #6227 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contrib: easy pr welcome team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@h-a-n-a