New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move state validation back into the value objects #581
Comments
Hi @TimWolla, Indeed |
4 tasks
Hi @TimWolla, This will be deprecated by #589.
It is strange at first sight, but I don't know how to swith from a base64 encoded to a binary value for WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
This request is somewhat similar to #464: I've noticed that the
PublicKeyCredentialDenormalizer
verifies that theid
andrawId
match, but thePublicKeyCredential
does not, possibly allowing the developer to create aPublicKeyCredential
that is internally inconsistent.In fact, if both IDs need to match up, why is it necessary to explicitly pass both of them. Should
PublicKeyCredential
perhaps just have theid
as a parameter and calculate therawId
by itself?Example
No response
The text was updated successfully, but these errors were encountered: