Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Space in between buttons #3985

Merged
merged 3 commits into from
Sep 6, 2023
Merged

fix Space in between buttons #3985

merged 3 commits into from
Sep 6, 2023

Conversation

AsmaaNabilBakr
Copy link
Contributor

@AsmaaNabilBakr AsmaaNabilBakr commented Sep 4, 2023 •
edited
Loading

Closes #3891

What changed?
Set a fixed space between buttons to be 12px

before:
image
after:
image

before:
image
after:
image

before:
image
after:
image

before:
image
after:
image

@AsmaaNabilBakr AsmaaNabilBakr added the area/ui Issues that require front-end work label Sep 4, 2023
@AsmaaNabilBakr
Copy link
Contributor Author

AsmaaNabilBakr commented Sep 4, 2023 •
edited
Loading

@jpellizzari FYI, @TheGostKasper suggest another solution for #3891 so I create this PR to try and it works by:

  • using Flex component and gap property in EE.
  • remove Spacer and update gap in some components in OSS.
    instead of over right on styles in OSS.

EE PR : #3279

@AsmaaNabilBakr AsmaaNabilBakr marked this pull request as ready for review September 4, 2023 20:10
@AsmaaNabilBakr AsmaaNabilBakr self-assigned this Sep 4, 2023
@AsmaaNabilBakr AsmaaNabilBakr changed the title fix spaces fix Space in between buttons Sep 4, 2023
@AsmaaNabilBakr AsmaaNabilBakr mentioned this pull request Sep 4, 2023
Merged
1 task
@AsmaaNabilBakr AsmaaNabilBakr merged commit 83110e5 into main Sep 6, 2023
14 checks passed
@AsmaaNabilBakr AsmaaNabilBakr deleted the adjust-spacing branch September 6, 2023 12:41
@weave-gitops-bot weave-gitops-bot mentioned this pull request Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheGostKasper TheGostKasper TheGostKasper approved these changes

@jpellizzari jpellizzari jpellizzari approved these changes

Assignees

@AsmaaNabilBakr AsmaaNabilBakr

Labels
area/ui Issues that require front-end work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Space in between buttons and weird black line
3 participants
@AsmaaNabilBakr @jpellizzari @TheGostKasper