JWT cookie fetcher converted to session storage. #3946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigkevmcd
force-pushed
the
session-storage
branch
4 times, most recently
from
101f124 to
d9250a0
Compare
foot
reviewed
Aug 28, 2023
foot
reviewed
Aug 28, 2023
foot
reviewed
Aug 29, 2023
| @@ -186,12 +187,16 @@ func runCmd(cmd *cobra.Command, args []string) error { | |||
| return fmt.Errorf("couldn't get current namespace") | |||
| } | |||
|
|
|||
| sessionManager := scs.New() | |||
| // TODO: Make this configurable | |||
| sessionManager.Lifetime = 24 * time.Hour | |||
There was a problem hiding this comment.
Could make this a flag, but 24h is pretty good for now too.
foot
approved these changes
Aug 29, 2023
bigkevmcd
force-pushed
the
session-storage
branch
from
6d5e2d7 to
20fc01a
Compare
Add initial session storage This pulls in the scs package for storing sessions. This means that cookies are stored in-memory for now, with a short cookie being sent to the user's browser, we access the old ID and Refresh cookies from the session.
bigkevmcd
force-pushed
the
session-storage
branch
from
20fc01a to
5c617f9
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
What changed?
Add initial session storage
This pulls in the scs package for storing sessions.
This means that cookies are stored in-memory for now, with a short cookie being sent to the user's browser, we access the old ID and Refresh cookies from the session.
NOTE: This is an initial release of this code, we will provide support for configuring external storage.
Why was this change made?
Support longer cookies
How was this change implemented?
How did you validate the change?
Tests and running the code
Release notes
Switching to session storage for cookies.
Documentation Changes