From 24ddf98c143790e0b240ec0b665104c43b76cffa Mon Sep 17 00:00:00 2001 From: yiannis Date: Tue, 7 Nov 2023 10:03:53 +0000 Subject: [PATCH 1/2] docs: Add ADR for creating sources --- docs/adrs/0023-create-sources-from-the-ui.md | 24 ++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 docs/adrs/0023-create-sources-from-the-ui.md diff --git a/docs/adrs/0023-create-sources-from-the-ui.md b/docs/adrs/0023-create-sources-from-the-ui.md new file mode 100644 index 0000000..6ae0fb4 --- /dev/null +++ b/docs/adrs/0023-create-sources-from-the-ui.md @@ -0,0 +1,24 @@ +# 23. Create Flux sources from the UI + +Date: 2023-11-06 + +## Status + +Accepted + +## Context + +Weave GitOps Enterprise (WGE) does not currently support the creation of Flux sources (GitRepository, HelmRepository, OCIRepository etc.) through the UI. + +## Decision + +We will enable the creation of Flux sources in the WGE UI by replicating the functionality offered by the [Flux CLI](https://fluxcd.io/flux/cmd/flux_create_source/). + +This means that the UI will make no attempt to additionally create secrets that are referenced by the Flux sources being created. Instead, the user will be asked to enter the name of a secret in the Create source UI form, that the source will reference. + + +## Consequences + +The decision to forgo secret creation means that users that create sources that reference secrets, will need to create those secrets prior to creating a source that relies on them. Although this is not an ideal workflow, it is still worth doing for the following reasons: +- Not all sources will be referencing secrets, examples of such sources are public Helm repositories of popular tools or when workload identity is configured. +- The proposed solution does not preclude us from enhancing this feature later to also create secrets (possibly via the use of ExternalSecrets) \ No newline at end of file From 70864a7a5ebdf62cb53092383a0facd56f93ef04 Mon Sep 17 00:00:00 2001 From: yiannis Date: Wed, 8 Nov 2023 13:44:20 +0000 Subject: [PATCH 2/2] docs: Add new ADR to README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 0867e2f..e48f779 100644 --- a/README.md +++ b/README.md @@ -24,6 +24,7 @@ This is for tracking weaveworks internal information on weave-gitops. Will inclu - [20. Explorer Monitoring](docs/adrs/0020-explorer-monitoring.md) - [21. Query Scaling Implementation Decisions](docs/adrs/0021-query-scaling-implementation-decisions.md) - [22. Explorer Collector Deletion Detection](docs/adrs/0022-explorer-collector-deletion-detection.md) +- [23. Create Sources from the UI](docs/adrs/0023-create-sources-from-the-ui.md)